Re: [RFC v1.1 1/5] crypto: GnuPG based MPI lib

From: Dmitry Kasatkin
Date: Wed Aug 17 2011 - 06:49:23 EST


On 16/08/11 03:57, James Morris wrote:
> On Thu, 11 Aug 2011, Dmitry Kasatkin wrote:
>
>> From: Dmitry Kasatkin <dmitry.kasatkin@xxxxxxxxx>
>>
>> Adds the multi-precision-integer maths library which was originally taken
>> from GnuPG and ported to the kernel by (among others) David Howells.
>> This version is taken from Fedora kernel 2.6.32-71.14.1.el6.
>
> First thing -- this code needs to be formatted using kernel coding style.
>
>
> - James

The code is inherited from GnuPG which does not follow kernel coding
standard. There are lots of "checkpatch" errors and warnings..
Do you say it must be reformatted?

- Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/