Re: [PATCH 2/2] mmc: prevent aggressive clock gating to race with ios updates

[Linus Walleij]

On Mon, Aug 15, 2011 at 12:03 PM, Mika Westerberg
<mika.westerberg@xxxxxxxxxxxxxxx> wrote:

> We have seen at least two different races when clock gating kicks in in a
> middle of ios structure update.
>
> First one happens when ios->clock is changed outside of aggressive clock
> gating framework, for example via mmc_set_clock(). The race might happen
> when we run following code:

Patch looks entirely sane if you deal with my considerations
in [1/2] replacing mmc_host_clk_gate_[disable|enable] with
plain mmc_host_clk_[ungate|gate]() or renamed versions
of these respectively.

Thanks,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/