Re: [RFC][PATCH 1/8] perf: Separate out trace-cmd parse-eventsfrom perf files

From: Steven Rostedt
Date: Tue Aug 16 2011 - 20:32:15 EST


On Tue, 2011-08-16 at 18:08 -0600, David Ahern wrote:

> > They are based off of v3.0. You can get these patches from my repo as
> > described in the 0/8 announce email.
>
> Unfortunately I hastily deleted the 0/8 thread while on vacation last
> week (gmail on Android thing), so I apologize for shifting the discussion.

Understood.

>
> With a little bit of hacking on top of your patches I was able to get
> the trace-cmd plugins working with perf. e.g.,
> qemu-kvm 11971 [001] 30401.777391: kvm_apic_accept_irq: apicid 0
> vec 239 (Fixed|edge)
> qemu-kvm 11971 [001] 30401.777405: kvm_inj_virq: irq 239
> qemu-kvm 11971 [001] 30401.777415: kvm_entry: vcpu 0
> qemu-kvm 11971 [001] 30401.777430: kvm_exit: reason APIC_ACCESS
> rip 0xffffffff8101dbe4 info 10b0 0

That's awesome!

>
> So, what is the next step for making this a reality -- i.e., getting the
> common code into a lib in tools?

Yeah, once everyone agrees with everything. I personally prefer things
to be in tools/lib/... and have all other tools depend on it. For the
names of these libraries, I'm game for anything.

Arnaldo, what's your preference, as you were the one that suggested that
it not be called libperf?

But I think this is a great step forward in making ftrace and perf work
better together :)

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/