Re: [patch] xen-blkback: sync I/O after backend disconnected

From: Joe Jin
Date: Tue Aug 16 2011 - 02:57:19 EST


On 08/15/11 22:46, Christoph Hellwig wrote:
> On Mon, Aug 15, 2011 at 12:55:02PM +0800, Joe Jin wrote:
>> When backend disconnect, sync IO requests to the disk.
>
> Care to explain why?

When backend disconnect, I think we'd better flush all dirty data
to the disk ASAP.

>
> Also you'll just need a sync_blockdev, fsync_bdev does far to many
> things that don't make any sense when you don't have a file system
> mounted on a device.
>

xen-blkback support physical device and loopback file, so I think
here should be fsync_bdev()?

Thanks,
Joe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/