[PATCHv2] printk: Remove bounds checking for log_prefix

From: William Douglas
Date: Mon Aug 15 2011 - 17:54:12 EST


Currently log_prefix is testing that the first character of the
log level and facility is less than '0' and greater than '9' (which
is always false).

Since the code being updated works because strtoul bombs out (endp isn't
updated) and 0 is returned anyway just remove the check and don't change
the behavior of the function.
Signed-off-by: William Douglas <william.douglas@xxxxxxxxx>
---
kernel/printk.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/kernel/printk.c b/kernel/printk.c
index 37dff34..4a0d2ed 100644
--- a/kernel/printk.c
+++ b/kernel/printk.c
@@ -590,9 +590,6 @@ static size_t log_prefix(const char *p, unsigned int *level, char *special)
/* multi digit including the level and facility number */
char *endp = NULL;

- if (p[1] < '0' && p[1] > '9')
- return 0;
-
lev = (simple_strtoul(&p[1], &endp, 10) & 7);
if (endp == NULL || endp[0] != '>')
return 0;
--
1.7.6

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/