[PATCH] staging: rts_pstor: dont cast void* from kmalloc()

From: Thomas Meyer
Date: Sat Aug 13 2011 - 10:14:47 EST


From: Thomas Meyer <thomas@xxxxxxxx>

Casting (void *) value returned by kmalloc is useless
as mentioned in Documentation/CodingStyle, Chap 14.

The semantic patch that makes this output is available
in scripts/coccinelle/api/alloc/drop_kmalloc_cast.cocci.

More information about semantic patching is available at
http://coccinelle.lip6.fr/

Signed-off-by: Thomas Meyer <thomas@xxxxxxxx>
---

diff -u -p a/drivers/staging/rts_pstor/sd.c b/drivers/staging/rts_pstor/sd.c
--- a/drivers/staging/rts_pstor/sd.c 2011-07-28 15:32:18.233251740 +0200
+++ b/drivers/staging/rts_pstor/sd.c 2011-08-01 19:57:13.347362265 +0200
@@ -4139,7 +4139,7 @@ int sd_execute_read_data(struct scsi_cmn
cmd[3] = srb->cmnd[5];
cmd[4] = srb->cmnd[6];

- buf = (u8 *)kmalloc(data_len, GFP_KERNEL);
+ buf = kmalloc(data_len, GFP_KERNEL);
if (buf == NULL) {
TRACE_RET(chip, TRANSPORT_ERROR);
}
@@ -4385,7 +4385,7 @@ int sd_execute_write_data(struct scsi_cm
u16 i;
u8 *buf;

- buf = (u8 *)kmalloc(data_len, GFP_KERNEL);
+ buf = kmalloc(data_len, GFP_KERNEL);
if (buf == NULL) {
TRACE_RET(chip, TRANSPORT_ERROR);
}



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/