Re: [PATCH] pnp: replace deprecated __check_region to request_region

[Bjorn Helgaas]

On Thu, Aug 11, 2011 at 10:03 PM, Wang Shaoyan <stufever@xxxxxxxxx> wrote:
> I can understand your worry, but back to beginning, just as the
> subject of the patch: "replace deprecated __check_region to
> request_region", I think this patch is still need, although it can't
> solve the problems both you guys mentioned. Do you agree it?

Your patch is presented as "no functional change," but in fact, the
current code does not leave the region reserved, while with your patch
it does.  This is quite a large change and I think it will break
things.

I would like to see the PNP core reserve resources, but it should be
done for all resources of all device.  Your patch only affects ioports
(I think we should do memory as well), and it only affects the
assignment path (I don't think we do this for every device we
enumerate).  And it effectively adds a region reservation without
adding a corresponding release.

Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/