Re: [patch 1/2] mm: vmscan: fix force-scanning small targets withoutswap

From: Michal Hocko
Date: Fri Aug 12 2011 - 09:13:21 EST


On Fri 12-08-11 15:10:42, Michal Hocko wrote:
> On Thu 11-08-11 22:31:54, Johannes Weiner wrote:
> > Without swap, anonymous pages are not scanned. As such, they should
> > not count when considering force-scanning a small target if there is
> > no swap.
> >
> > Otherwise, targets are not force-scanned even when their effective
> > scan number is zero and the other conditions--kswapd/memcg--apply.
> >
> > Signed-off-by: Johannes Weiner <jweiner@xxxxxxxxxx>
>
> We are calculating nr_force_scan even if it is not needed but this
> shouldn't hurt.

Ahh and the second patch removes that calculation. Sorry for noise.

> Reviewed-by: Michal Hocko <mhocko@xxxxxxx>

--
Michal Hocko
SUSE Labs
SUSE LINUX s.r.o.
Lihovarska 1060/12
190 00 Praha 9
Czech Republic
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/