Re: [PATCH v2] usb: musb: ux500: optimize DMA callback routine

From: Felipe Balbi
Date: Fri Aug 12 2011 - 05:41:39 EST


Hi,

On Mon, Aug 08, 2011 at 01:01:06PM +0200, Per Forlin wrote:
> From: Per Forlin <per.forlin@xxxxxxxxxx>
>
> Skip the use of work queue and call musb_dma_completion() directly from
> DMA callback context.
>
> Here follows measurements on a Snowball board with ondemand governor active.
>
> Performance using work queue:
> (105 MB) copied, 6.23758 s, 16.8 MB/s
> (105 MB) copied, 5.7151 s, 18.3 MB/s
> (105 MB) copied, 5.83583 s, 18.0 MB/s
> (105 MB) copied, 5.93611 s, 17.7 MB/s
>
> Performance without work queue
> (105 MB) copied, 5.62173 s, 18.7 MB/s
> (105 MB) copied, 5.61811 s, 18.7 MB/s
> (105 MB) copied, 5.57817 s, 18.8 MB/s
> (105 MB) copied, 5.58549 s, 18.8 MB/s
>
> Signed-off-by: Per Forlin <per.forlin@xxxxxxxxxx>
> Acked-by: Mian Yousaf Kaukab<mian.yousaf.kaukab@xxxxxxxxxxxxxx>

this patch doesn't apply anymore:

$ patch -p1 --dry-run < ~/apply.diff
patching file drivers/usb/musb/ux500_dma.c
Hunk #2 FAILED at 55.
Hunk #3 succeeded at 325 (offset -4 lines).
Hunk #4 succeeded at 341 (offset -4 lines).
Hunk #5 succeeded at 367 (offset -4 lines).
1 out of 5 hunks FAILED -- saving rejects to file drivers/usb/musb/ux500_dma.c.rej

care to rebase on top of 3.1-rc1. Thanks

--
balbi

Attachment: signature.asc
Description: Digital signature