Re: [PATCH] i2c/tegra: I2C driver uses the suspend_noirq/resume_noirq

From: Mark Brown
Date: Thu Aug 11 2011 - 23:14:54 EST


On Thu, Aug 11, 2011 at 07:59:27PM -0700, Colin Cross wrote:
> On Thu, Aug 11, 2011 at 5:45 PM, Mark Brown

> > For example with ASoC we'd sort all the components before the ASoC card
> > without regard for their bus dependencies or any other dependencies they
> > have (eg, their regulators). Since the ASoC card is a platform device
> > it's likely to have registered early with no regard for where the buses
> > the card needs are registered. I'd expect there's a reasonable chance
> > it'll actually make things worse in the short term.

> You can't just move everything after the card, you have to move
> everything after the last device that was probed, and it only works if
> nothing depends on any of the devices that are moved.

Sorry, I said that the wrong way round due to trying to reply quickly -
the card would be the thing that moves since that's the thing that
actually does the suspend but we've *no* idea which device we need to
move it after. Since all the function does is a direct move after or
before a single device all we can do is pick one and pray that it's the
right device.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/