Re: [PATCH 2/2] Enable 'make CONFIG_FOO=y oldconfig'

From: Michal Marek
Date: Thu Aug 11 2011 - 11:24:14 EST


On 11.8.2011 17:07, David Woodhouse wrote:
> On Thu, 2011-08-11 at 10:57 -0400, Arnaud Lacombe wrote:
>>
>> FWIW, this is the broken behavior I have been pointing all along...
>>
>> If kconfig hard failed on such case, we would not need such Kbuild
>> black-magic.
>>
>> From my point of view, if environment override there should be, it
>> should behave the same as the all.config logic and hard fail when an
>> override has not been met.
>> Code wise, this would translate as backend code path being the same.
>
>
> The patches I have so far *do* behave the same as the all.config logic,
> because the back end code *is* fairly much the same. I was looking at
> the all.config logic when I wrote the patch to kconfig.
>
> It *doesn't* currently hard fail. But I'm more than happy to make it do
> so. I think you're right; that makes most sense.

One of my use cases for all.config is

$ cp .../older-working-config all.config
$ make KCONFIG_ALLCONFIG=1 allmodconfig

i.e. reuse what is possible from an older config and enable all new
options. Surely it sometimes results in suboptimal configuration with
unwanted debug options enabled, but most of the time it works. I won't
be happy if you make it hard fail because of renamed or removed config
options.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/