Re: [PATCH v2 2/2] blktrace: add FLUSH/FUA support

[Jens Axboe]

On 2011-08-10 15:53, Jeff Moyer wrote:
> Namhyung Kim <namhyung@xxxxxxxxx> writes:
> 
>> Add FLUSH/FUA support to blktrace. As FLUSH precedes WRITE and/or
>> FUA follows WRITE, use the same 'F' flag for both cases and
>> distinguish them by their (relative) position. The end results
>> look like (other flags might be shown also):
>>
>>  - WRITE:            W
>>  - WRITE_FLUSH:      FW
>>  - WRITE_FUA:        WF
>>  - WRITE_FLUSH_FUA:  FWF
> 
> I was hoping we'd go with Jens' suggestion of relacing W with F for flush,
> and have FUA appear after that.  However, I can live with this, so if
> others like it, it's fine by me.

The single 'F' would have been cleaner, but at least this is consistent.
Applied, thanks.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/