Re: [PATCH 0/2][cleanup] memcg: renaming of mem variable to memcg

[Michal Hocko]

On Thu 11-08-11 13:46:19, Raghavendra K T wrote:
> On 08/11/2011 01:23 PM, Michal Hocko wrote:
> >On Wed 10-08-11 22:59:17, Raghavendra K T wrote:
> >>Hi,
> >>  This is the memcg cleanup patch for that was talked little ago to change the  "struct
> >>  mem_cgroup *mem" variable to  "struct mem_cgroup *memcg".
> >>
> >>  The patch is though trivial, it is huge one.
> >>  Testing : Compile tested with following configurations.
> >>  1) CONFIG_CGROUP_MEM_RES_CTLR=y  CONFIG_CGROUP_MEM_RES_CTLR_SWAP=y
> >>  2) CONFIG_CGROUP_MEM_RES_CTLR=y  CONFIG_CGROUP_MEM_RES_CTLR_SWAP=n
> >>  3) CONFIG_CGROUP_MEM_RES_CTLR=n  CONFIG_CGROUP_MEM_RES_CTLR_SWAP=n
> >
> >How exactly have you tested? Compiled and compared before/after binaries
> >(it shouldn't change, right)?
> Yes, But idea was to ensure that both #ifdef and #else part are hit
> during compilation, which could expose some corrections needed.

I am not sure I understand. You have used different combinations of
configuration to trigger all #ifdefs but that doesn't change anything on
the fact that the code should be exactly same before and after your
patch, right?

-- 
Michal Hocko
SUSE Labs
SUSE LINUX s.r.o.
Lihovarska 1060/12
190 00 Praha 9    
Czech Republic
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/