Re: [PATCH 1/2][cleanup] memcg: renaming of mem variable to memcg

From: Michal Hocko
Date: Thu Aug 11 2011 - 04:05:06 EST


On Wed 10-08-11 22:59:29, Raghavendra K T wrote:
[...]
> This patch renames all mem variables to memcg in source file.

__mem_cgroup_try_charge for example uses local mem which cannot be
renamed because it already has a memcg argument (mem_cgroup **) then we
have mem_cgroup_try_charge_swapin and mem_cgroup_prepare_migration which
use mem_cgroup **ptr (I guess we shouldn't have more of them).
I think that __mem_cgroup_try_charge should use ptr pattern as well.
Other than that I think the clean up is good.

With __mem_cgroup_try_charge:
Acked-by: Michal Hocko <mhocko@xxxxxxx>

Thanks
--
Michal Hocko
SUSE Labs
SUSE LINUX s.r.o.
Lihovarska 1060/12
190 00 Praha 9
Czech Republic
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/