Re: [PATCH v3 1/2] x86: Enable fast strings on Intel if BIOS hasn't already

From: Andrew Lutomirski
Date: Wed Aug 10 2011 - 10:50:04 EST


On Tue, Aug 9, 2011 at 11:40 AM, Yu, Fenghua <fenghua.yu@xxxxxxxxx> wrote:
>> -----Original Message-----
>> From: Andy Lutomirski [mailto:luto@xxxxxxx]
>> Sent: Tuesday, August 09, 2011 5:41 AM
>> To: x86@xxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
>> Cc: Yu, Fenghua; Matthew Garrett; Len Brown; linux-
>> acpi@xxxxxxxxxxxxxxx; Ingo Molnar; Andy Lutomirski
>> Subject: [PATCH v3 1/2] x86: Enable fast strings on Intel if BIOS
>> hasn't already
>>
>> Intel SDM volume 3A, 8.4.2 says:
>>
>>   Software can disable fast-string operation by clearing the
>>   fast-string-enable bit (bit 0) of IA32_MISC_ENABLE MSR.
>>   However, Intel recomments that system software always enable
>>   fast-string operation.
>>
>> The Intel DQ67SW board (with latest BIOS) disables fast string
>> operations if TXT is enabled.  A Lenovo X220 disables it regardless
>> of TXT setting.  I doubt I'm the only person with a dumb BIOS like
>> this.
>>
>> Signed-off-by: Andy Lutomirski <luto@xxxxxxx>
>> ---
>>  arch/x86/kernel/cpu/intel.c |   28 +++++++++++++++++++++++-----
>>  1 files changed, 23 insertions(+), 5 deletions(-)
>
> Signed-off-by: Fenghua Yu <fenghua.yu@xxxxxxxxx>
>
>

Please don't apply. This patch breaks !CONFIG_SMP. I'll send a fixed
patch later on.

--Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/