Re: [PATCH 2/2] Enable 'make CONFIG_FOO=y oldconfig'

[Arnaud Lacombe]

Hi,

On Tue, Aug 9, 2011 at 10:14 AM, Michal Marek <mmarek@xxxxxxx> wrote:
> On 31.7.2011 02:05, Arnaud Lacombe wrote:
>>
>> Hi,
>>
>> On Sat, Jul 30, 2011 at 7:53 PM, H. Peter Anvin<hpa@xxxxxxxxx>  wrote:
>>>
>>> On 07/30/2011 04:44 PM, Arnaud Lacombe wrote:
>>>>
>>>> Beside that, the one thing I dislike with your patch is that it is
>>>> unconditional and global to all symbols, and you have no way to forbid
>>>> the environment to override a value.
>>>>
>>>
>>> Why????
>>>
>> Because kconfig might not be ran exclusively from a fully controlled
>> and restricted environment ? Not to mention that it is used by other
>> people than the linux kernel folks.
>
> Well, it has always been possible to trick kbuild (not kconfig) into
> accepting CONFIG_* options from environment, because unset kconfig options
> in auto.conf are not seen by make. Of course this is completely fragile,
> because there is no dependency checking and such variables are only seen by
> make and do not appear in autoconf.h. So a patch that teaches kconfig to
> read options from the environment would actually make some (albeit currently
> "illegal") use cases work correctly :).
>
kconfig can already set symbol value from the environment. The only
limitation I can see is that it is not optional and require an
explicit environment variable name.

 - Arnaud
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/