Re: [Xen-devel] [PATCH 1/3] xen/pv-on-hvm kexec: add xs_introduce toshutdown watches from old kernel

[Olaf Hering]

On Tue, Aug 09, Ian Campbell wrote:

> > +++ linux-3.0/drivers/xen/xenbus/xenbus_xs.c

> > +	return xs_error(xs_talkv(XBT_NIL, XS_INTRODUCE, iov,
> > +				 ARRAY_SIZE(iov), NULL));
> 
> What should we do if this fails?

There is not much other than printk and move on.
A kexec boot cant be detected from withing kexec.

> > +	snprintf(domid, sizeof(domid), "%u", DOMID_SELF);
> > +	snprintf(mfn, sizeof(mfn), "%lu", xen_store_mfn);
> > +	snprintf(port, sizeof(port), "%d", xen_store_evtchn);
> 
> These can be within the if, or better within the xs_introduce function
> itself.

Yes, thats true. I will rearrange the code.

Olaf
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/