Re: [PATCH 05/11] DIO: Separate map_bh from dio v2

[Jeff Moyer]

Andi Kleen <andi@xxxxxxxxxxxxxx> writes:

> From: Andi Kleen <ak@xxxxxxxxxxxxxxx>
>
> Only a single b_private field in the map_bh buffer head is needed after
> the submission path. Move map_bh separately to avoid storing
> this information in the long term slab.
>
> This avoids the weird 104 byte hole in struct dio_submit which also needed
> to be memseted early.
>
> v2: b_private->private (hch)
> Signed-off-by: Andi Kleen <ak@xxxxxxxxxxxxxxx>

> @@ -1045,6 +1051,7 @@ direct_io_worker(int rw, struct kiocb *iocb, struct inode *inode,
>  	ssize_t ret = 0;
>  	ssize_t ret2;
>  	size_t bytes;
> +	struct buffer_head map_bh = { 0, };

So long as that zeroes the entire struct (seems to), I'm okay with this patch.

Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/