Re: [Intel-gfx] [PATCH 3/4] drm/i915: Fix PCH port pipe select inCPT disable paths

From: Jesse Barnes
Date: Mon Aug 08 2011 - 12:31:54 EST


On Sat, 6 Aug 2011 10:54:07 -0700
Keith Packard <keithp@xxxxxxxxxx> wrote:

> CPT pipe select is different from previous generations (using two bits
> instead of one). All of the paths from intel_disable_pch_ports were
> not making this distinction.
>
> Mode setting with pipe A turned off would then also force all outputs
> on pipe B to get turned off as the disable code would mistakenly
> decide that all of these outputs were on pipe A and turn them off.
>
> This is an extension of the CPT DP disable fix (why didn't I fix this then?)
>
> Signed-off-by: Keith Packard <keithp@xxxxxxxxxx>
> ---
> drivers/gpu/drm/i915/i915_reg.h | 13 ++-----
> drivers/gpu/drm/i915/intel_display.c | 60 ++++++++++++++++++++++++++++++---
> 2 files changed, 58 insertions(+), 15 deletions(-)
>

Reviewed-by: Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx>

--
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/