Re: fix rcu annotations noise in cred.h

[Paul E. McKenney]

On Mon, Aug 08, 2011 at 09:18:29AM +0100, David Howells wrote:
> 
> Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
> 
> >  #define current_cred() \
> > -	(current->cred)
> > +	(*(__force struct cred **)&current->cred)
> 
> No.  You've cast away the const.  Please don't do that.
> 
> Paul: isn't there some better way of doing this using an RCU wrapper macro?
> 
> 	#define current_cred() \
> 		rcu_dereference_protected(current->cred, 1) 
> 
> Perhaps?

This is indeed what rcu_dereference_protected() is intended for.

							Thanx, Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/