Re: list corruption in the last few days. (block ? crypto ?)

From: Pekka Enberg
Date: Mon Aug 08 2011 - 01:18:56 EST


Hi Linus,

On Sun, Aug 7, 2011 at 11:58 AM, Pekka Enberg <penberg@xxxxxxxxxx> wrote:

Christoph, I've been reading the code and spotted two potential issues in
__slab_free(). The first one seems like an off-by-one where our comparison
in deactivate_slab() doesn't match __slab_free.

The other one is remove_full() call in __slab_free() that can get called
even if cache debugging is not enabled.

Hmm?

On Sun, 7 Aug 2011, Linus Torvalds wrote:
I'd like to do -rc1 today, regardless of whether this fixes things or
not (-rc1 is already a few days delayed).

The patch seems to be a good fix, and a likely candidate for the
corruption. Commit log and sign-off? I assume you've given it some
testing, even if you couldn't reproduce the original issue?

No, I haven't tested the patch myself but here's one in proper format in case someone wants to test it.

Pekka