Re: [patch 1/5] mm: page_alloc: increase __GFP_BITS_SHIFT to include__GFP_OTHER_NODE

From: Rik van Riel
Date: Fri Aug 05 2011 - 10:17:13 EST


On 07/25/2011 04:19 PM, Johannes Weiner wrote:
From: Johannes Weiner<hannes@xxxxxxxxxxx>

__GFP_OTHER_NODE is used for NUMA allocations on behalf of other
nodes. It's supposed to be passed through from the page allocator to
zone_statistics(), but it never gets there as gfp_allowed_mask is not
wide enough and masks out the flag early in the allocation path.

The result is an accounting glitch where successful NUMA allocations
by-agent are not properly attributed as local.

Increase __GFP_BITS_SHIFT so that it includes __GFP_OTHER_NODE.

Signed-off-by: Johannes Weiner<hannes@xxxxxxxxxxx>

Acked-by: Rik van Riel <riel@xxxxxxxxxx>

--
All rights reversed
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/