Re: linux-next: Tree for Aug 4 (zcache)

From: Thadeu Lima de Souza Cascardo
Date: Thu Aug 04 2011 - 17:54:31 EST


On Thu, Aug 04, 2011 at 02:51:45PM -0700, Randy Dunlap wrote:
> On Thu, 4 Aug 2011 14:44:41 -0700 Greg KH wrote:
>
> > On Thu, Aug 04, 2011 at 02:24:37PM -0700, Randy Dunlap wrote:
> > > On Thu, 4 Aug 2011 14:58:34 +1000 Stephen Rothwell wrote:
> > >
> > > > Hi all,
> > > >
> > > > Just in case anyone needs reminding: Please do not add anything destined
> > > > for v3.2 into linux-next included trees until after v3.1-rc1.
> > >
> > >
> > > on i386:
> > >
> > > drivers/built-in.o: In function `zcache_pampd_create':
> > > zcache-main.c:(.text+0x159b8f): undefined reference to `__udivdi3'
> >
> > Very wierd, what would cause that?
>
> I don't see what's weird about it.
>
> Probably one of these divisions:
>
> if (curr_pers_pampd_count >
> (zv_page_count_policy_percent * totalram_pages) / 100)
> goto out;
>
> or
>
> zv_mean_zsize = xv_get_total_size_bytes(cli->xvpool) /
> curr_pers_pampd_count;
>

The second one. xv_get_total_size_bytes returns u64. I am just
compile-testing a fix.

>
> ---
> ~Randy
> *** Remember to use Documentation/SubmitChecklist when testing your code ***

Attachment: signature.asc
Description: Digital signature