Re: [PATCH v2] of/address: Add of_iomap_nocache

From: Grant Likely
Date: Thu Aug 04 2011 - 12:59:14 EST


On Thu, Aug 4, 2011 at 5:56 PM, Scott Wood <scottwood@xxxxxxxxxxxxx> wrote:
>> +#ifndef SPARC
>> +extern void __iomem *of_iomap_nocache(struct device_node *device, int
>> index);
>> +#else
>> +static inline void __iomem *of_iomap_nocache(struct device_node *device,
>> +               int index)
>> +{
>> +       return of_iomap(device, index);
>> +}
>> +#endif
>
> Why is sparc special?  It looks like it defines ioremap_nocache() as
> ioremap() just like powerpc and some others, so shouldn't the normal
> of_iomap_nocache just work?

No, the implementation is completely different. SPARC preparses all
the reg properties. Everyone else does not.

g.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/