Re: [PATCH 1/1] xen: asm/io.h should not include xen.h if XEN isdisabled

From: Dmitry Kasatkin
Date: Thu Aug 04 2011 - 05:47:46 EST




On 04/08/11 04:04, Linus Torvalds wrote:
> On Wed, Aug 3, 2011 at 6:33 AM, Dmitry Kasatkin
> <dmitry.kasatkin@xxxxxxxxx> wrote:
>> XEN related content is behind the CONFIG_XEN flag in the io.h.
>> And <xen/xen.h> should be also behind CONFIG_XEN flag.
> Wouldn't it be much nicer to just move the '#include <xen/xen.h>' line down?
>
It is probably a mater of taste.. to keep includes on the top.
> Does the attached patch work for you?
>
Yes, it works...
I experienced a problem in building some modules because of that include.
In older kernel version (before .38 or so) everything was fine - it was
not <xen/xen.h> includes in io.h

> Linus

Thank you..

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/