Re: [PATCH] nbd: nbd sysfs framework

From: Greg KH
Date: Thu Aug 04 2011 - 01:26:06 EST


On Wed, Aug 03, 2011 at 10:17:04PM -0400, Paul Clements wrote:
> On Wed, Aug 3, 2011 at 7:34 PM, Greg KH <greg@xxxxxxxxx> wrote:
> > On Wed, Aug 03, 2011 at 07:15:51PM -0400, Paul Clements wrote:
> >> Description: The patch creates a new sysfs entry framework for nbd.
> >
> > Why?  What does this buy us except an increase in code size for no added
> > benifit?  You seem to be stripping out the driver layer here and using
> > "raw" kobjects, why?
>
> Not sure what I was thinking...just in a hurry, I think.
>
> Is the following a little better?

I don't know, I still fail to understand _why_ this patch is needed.

Why are you doing this? What is the goal? What is wrong with the
existing code that it doesn't work for you?

confused,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/