Re: loop device auto release patch

[Andrew Morton]

On Wed, 03 Aug 2011 21:58:24 -0400 Phillip Susi <psusi@xxxxxxxxxx> wrote:

> On 07/15/2011 03:19 PM, Andrew Morton wrote:
> > The patch appears to do two unrelated things.  That's generally frowned
> > upon, but doesn't bother me much if the patch is small.
> > 
> > Still, splitting it into two patches (in which the bugfix is staged
> > first) would be advantageous for people who might wish to backport the
> > fix into earlier kernels.
> 
> It looks like this got stalled and someone emailed me asking what
> happened to it.  I'm not sure that splitting the patch in two makes
> sense.  I don't see how it does two unrelated things.  The uevent
> problem was caused by the argument being NULL.  This patch just removes
> the argument since it is entirely unnecessary.  Given that the argument
> is gone and can no longer be passed as NULL, the tests for NULL are
> rendered moot, and so removing them seems quite related.  I suppose you
> could do the first and not the second, but then you would be leaving
> cruft behind.

Am still waiting for someone to say that this is tested.

And what is "my previous patch"?  "emit uevent on auto release"?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/