Re: [PATCH -mmotm] media: video/adp1653.c needs module.h

From: Stephen Rothwell
Date: Wed Aug 03 2011 - 20:24:01 EST


Hi Randy,

On Wed, 3 Aug 2011 10:12:26 -0700 Randy Dunlap <rdunlap@xxxxxxxxxxxx> wrote:
>
> From: Randy Dunlap <rdunlap@xxxxxxxxxxxx>
>
> adp1653.c uses interfaces that are provided by <linux/module.h>
> and needs to include that header file to fix build errors.
>
> drivers/media/video/adp1653.c:453: warning: data definition has no type or storage class
> drivers/media/video/adp1653.c:453: warning: parameter names (without types) in function declaration
> drivers/media/video/adp1653.c:474: error: 'THIS_MODULE' undeclared (first use in this function)
> and more.
>
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxx>

That is a bug that is now in Linus' tree and this fix is pending in the
moduleh tree in linux-next. So this patch should go to Linus.

--
Cheers,
Stephen Rothwell sfr@xxxxxxxxxxxxxxxx
http://www.canb.auug.org.au/~sfr/

Attachment: pgp00000.pgp
Description: PGP signature