Re: [PATCH] Staging: comedi: fix printk issue in pcl818.c

From: Joe Perches
Date: Wed Aug 03 2011 - 03:13:26 EST


On Wed, 2011-08-03 at 10:54 +0530, Ravishankar wrote:
> From: Ravishankar <ravi.shankar@xxxxxxxxxxxxxxx>
> This is a patch to the pcl818.c file that fixes up a printk warning found by the checkpatch.pl tool

This patch does a lot more than fix a printk warning.

Please make your patch descriptions match your patch.

> drivers/staging/comedi/drivers/pcl818.c | 118 +++++++++++++++----------------

> @@ -1461,7 +1452,7 @@ static int ai_cmd(struct comedi_device *dev, struct comedi_subdevice *s)
> struct comedi_cmd *cmd = &s->async->cmd;
> int retval;
>
> - printk("pcl818_ai_cmd()\n");
> + dev_dbg(dev->hw_dev "pcl818_ai_cmd()\n");

Compile your patches _before_ sending them.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/