[PATCH] Fix a argument WARN bug of scripts/checkpatch.pl

From: Hui Zhu
Date: Tue Aug 02 2011 - 22:36:29 EST


Hi Joe,

Thanks for your help.

Best,
Hui

The following part is the original patch:

Get following error with a patch that have min_t error:
Use of uninitialized value in concatenation (.) or string at
scripts/checkpatch.pl line 1256.
WARNING:
This is because:
}
WARN("$call() should probably be ${call}_t($cast, $arg1, $arg2)\n" . $herecurr);
}
It lost the first argument.
So make a patch to fix it.

Signed-off-by: Hui Zhu <teawater@xxxxxxxxx>
Acked-by: Joe Perches <joe@xxxxxxxxxxx>
---
scripts/checkpatch.pl | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2574,7 +2574,8 @@ sub process {
} else {
$cast = $cast2;
}
- WARN("$call() should probably be ${call}_t($cast, $arg1, $arg2)\n" . $herecurr);
+ WARN("MINMAX",
+ "$call() should probably be ${call}_t($cast, $arg1, $arg2)\n" . $herecurr);
}
}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/