Re: [PATCH] efivars: fix warnings when CONFIG_PSTORE=n

From: Mike Waychison
Date: Tue Aug 02 2011 - 18:02:12 EST


On Tue, Aug 2, 2011 at 2:03 PM, Matthew Garrett <mjg59@xxxxxxxxxxxxx> wrote:
> On Tue, Aug 02, 2011 at 01:57:06PM -0700, Luck, Tony wrote:
>> drivers/firmware/efivars.c:161: warning: ‘utf16_strlen’ defined but not used
>> utf16_strlen() is only used inside CONFIG_PSTORE - put same #ifdef around the
>> definition of the function too.
>>
>> drivers/firmware/efivars.c:602: warning: initialization from incompatible pointer type
>> Between v1 and v2 of this patch series we decided to make the "part" number
>> unsigned - but missed fixing the stub version of efi_pstore_write()
>>
>> Signed-off-by: Tony Luck <tony.luck@xxxxxxxxx>
>
> Acked-by: Matthew Garrett <mjg@xxxxxxxxxx>

Acked-by: Mike Waychison <mikew@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/