Re: [PATCH] pti: add missing CONFIG_PCI dependency

[J Freyensee]

On 08/02/2011 08:11 AM, Randy Dunlap wrote:
> On Tue, 2 Aug 2011 10:08:34 +0200 Heiko Carstens wrote:
>
> > From: Heiko Carstens<heiko.carstens@xxxxxxxxxx>
> >
> > allmodconfig compile fails on s390 because of the new PTI driver:
> >
> > drivers/misc/pti.c:407:3: error: implicit declaration of function 'pci_iounmap'
> > drivers/misc/pti.c:410:3: error: implicit declaration of function 'pci_release_region'
> >
> > Add a 'depends on PCI' statement so it doesn't get compiled.
> >
> > Cc: J Freyensee<james_p_freyensee@xxxxxxxxxxxxxxx>

Greg, did you see the patch go your way?

http://marc.info/?l=linux-kernel&m=131007615706260&w=2

Should I res-submit this patch to you through the linux-next mailing list?

Thanks Greg,

J

> James has already acked my identical patch.
> The problem seems to be that we don't have a drivers/misc/ maintainter to
> merge the patch.
>
> Anyway:
> Acked-by: Randy Dunlap<rdunlap@xxxxxxxxxxxx>
>
>
> > Signed-off-by: Heiko Carstens<heiko.carstens@xxxxxxxxxx>
> > ---
> >   drivers/misc/Kconfig |    1 +
> >   1 file changed, 1 insertion(+)
> >
> > --- a/drivers/misc/Kconfig
> > +++ b/drivers/misc/Kconfig
> > @@ -146,6 +146,7 @@ config PHANTOM
> >
> >   config INTEL_MID_PTI
> >   	tristate "Parallel Trace Interface for MIPI P1149.7 cJTAG standard"
> > +	depends on PCI
> >   	default n
> >   	help
> >   	  The PTI (Parallel Trace Interface) driver directs
> > --
>
>
> ---
> ~Randy
> *** Remember to use Documentation/SubmitChecklist when testing your code ***


--
J (James/Jay) Freyensee
Storage Technology Group
Intel Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/