Re: [PATCH 2/7] MIPS: static should be at beginning of declaration

From: Ralf Baechle
Date: Tue Aug 02 2011 - 06:14:27 EST


On Sat, Jul 09, 2011 at 11:12:35PM +0200, Jesper Juhl wrote:

> Make sure that the 'static' keywork is at the beginning of declaration
> for arch/mips/include/asm/mach-jz4740/gpio.h
>
> This gets rid of warnings like
> warning: âstaticâ is not at beginning of declaration
> when building with -Wold-style-declaration (and/or -Wextra which also
> enables it).
> Also a few tiny whitespace changes.

> - const static struct jz_gpio_bulk_request i2c_pins[] = {
> + static const struct jz_gpio_bulk_request i2c_pins[] = {

Quite surprising - but that still was valid C - just type for example:

int typedef (*func(const char op))(int a, int b[static const a = 3]);

Ralf
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/