Re: [PATCH] char drivers: ramoops documentation

From: Randy Dunlap
Date: Mon Aug 01 2011 - 20:19:31 EST


On Mon, 1 Aug 2011 15:37:49 -0700 Sergiu Iordache wrote:

> On Mon, Aug 1, 2011 at 3:05 PM, Randy Dunlap <rdunlap@xxxxxxxxxxxx> wrote:
> > On Mon,  1 Aug 2011 14:26:50 -0700 Sergiu Iordache wrote:
> >
> >> Add a documentation file describing the usage of Ramoops
> >>
> >> Change-Id: I9dab9c4b9e4921b220574470372e330d32f9c63b
> >
> > eh?
> Sorry, was it the commit message you did not like or something else?

The "Change-Id:" line.
There was a discussion that began with a July 14 patch from Mike Waychison
<mikew@xxxxxxxxxx>:
Subject: [PATCH 1/2] Kconfig: Allow disabling of CONFIG_DEVPORT

that included the line:
Google-Bug-Id: 3177114

Basically we don't want umpteen zillion different such tags in commit
messages. I posted a patch last Friday:
Subject: [PATCH] Documentation: add Internal-reference-ID: patch tag

that allows people who want to track their internal references in commit
messages to use a common tag label/format:

Internal-reference-ID: <text>

<text> should not be a private (internal) URL.


> Thanks, I've updated the doc using your feedback. I have also
> rearranged the "1. Ramoops concepts" part to make it look better I
> think. I'll wait a bit for some more comments and then resubmit the
> new version of the patch.

Thanks.

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/