Re: [PATCH v3 2/2] Make hard lockup detection use timestamps

From: ZAK Magnus
Date: Mon Aug 01 2011 - 16:11:37 EST


On Mon, Aug 1, 2011 at 12:24 PM, Don Zickus <dzickus@xxxxxxxxxx> wrote:
> One idea I thought of to workaround this is to save the timestamp and the
> watchdog bool and restore after the stack dump.  It's a cheap hack and I
> am not to sure about the locking as it might race with
> touch_nmi_watchdog().  But it gives you an idea what I was thinking.
Yes, I see. Is the hackiness of it okay?

> Being in the nmi context, no one can normally touch these variables,
> except for another cpu using touch_nmi_watchdog() (or watchdog_enable()
> but that should never race in these scenarios).
Well, the soft lockup stuff is not a NMI but just a regular interrupt,
right? Is that also okay?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/