Re: [PATCH] mrst_pmu: driver for Intel Moorestown Power ManagementUnit

From: Alan Cox
Date: Mon Aug 01 2011 - 11:37:12 EST


On Mon, 01 Aug 2011 11:24:45 -0400 (EDT)
Len Brown <lenb@xxxxxxxxxx> wrote:

>
> > > + BUG_ON(pci_dev_num != mrst_devs[index].pci_dev_num);
> >
> > That strikes me as needlessly unfriendly, you could warn/return NULL and
> > propogate a WARN_ONCE back to the user.
>
> If a fit of friendlyness, I wrote the patch below.
> Let me know if it is not what you had in mind.

It's not so much the bug on as the fact it spews these if you boot it on
a non mrst box built with a generic kernel - which was the second part of
my comment and doesn't appear addressed.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/