Re: [PATCH 1/1] btrfs: btrfs_calc_avail_data_space cope with no read/writedevices V2

From: Josef Bacik
Date: Mon Aug 01 2011 - 11:24:43 EST


On 08/01/2011 09:38 AM, Andy Whitcroft wrote:
> When we mount a btrfs filesystem from read-only media there will be no
> read/write devices; for example mounting an SD card with its lock enabled.
> This triggers an immediate BUG during mount:
>
> kernel BUG at .../fs/btrfs/super.c:984!
>
> This is triggered by statfs when calculating the free space in the
> filesytem. We bug if the number of read/write devices is 0.
>
> This check seems spurious as the information collected is valid regardless
> of whether the devices are read-only or not. As the count is used to
> size the sort array it seems more correct to switch it to the number of
> open devices.
>
> BugLink: http://bugs.launchpad.net/bugs/816770
> Signed-off-by: Andy Whitcroft <apw@xxxxxxxxxxxxx>

Acked-by: Josef Bacik <josef@xxxxxxxxxx>

Thanks,

Josef
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/