Re: [PATCH 3/8] staging: vme: make [alloc|free]_consistent bridgespecific

[Manohar Vanga]

Hi Martyn,

> > Make PCI dependent functions ([alloc|free]_consistent() in
> > 'vme.c') bridge specific. By removing the dependency of the
> > VME bridge framework on PCI, this patch allows for addition of
> > non-PCI based VME bridges.
> > 
> 
> I like the approach, I think I agree with Dan, I'd rather see the locking
> inside the function for now.

Just noticed that the locking that Dan was referring to and the one you agree
with in the previous patch ([PATCH 2/8] staging: vme: allow explicit assignment
of bus numbers) and not this one. Which one are you referring to here?

--
/manohar
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/