Re: [PATCH 09/18] dmaengine/amba-pl08x: Schedule tasklet in case oferror interrupt

From: viresh kumar
Date: Fri Jul 29 2011 - 11:30:59 EST


On 7/29/11, Koul, Vinod <vinod.koul@xxxxxxxxx> wrote:
> On Fri, 2011-07-29 at 16:19 +0530, Viresh Kumar wrote:
>> + dev_err(&pl08x->adev->dev, "%s error interrupt, register value"
>> + "0x%08x\n", __func__, err);
> again this looks convoluted, and the stuff is quotes can be in single
> line :)

Will take care of this in all patches.

> but in tasklet you will call the client callback, so how does the client
> know if this was success or error? Did I miss anything?

No you didn't. I couldn't find a way in framework to report back to
client success or failure.
Is there any way? For now i have only kept error prints.

--
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/