Re: [PATCH] kswapd: assign new_order and new_classzone_idx afterwakeup in sleeping

From: Alex,Shi
Date: Thu Jul 28 2011 - 20:09:25 EST



> Post to linux-mm, cc me.
>
> > > Acked-by: Mel Gorman <mgorman@xxxxxxx>
> > >
> > > It won't be merged to -stable until it goes to mainline though so
> > > minimally you need to post this to linux-mm.
> > >
> > > For -stable, you should explain why it is a candidate. I didn't push
> > > the patch at the time because user problems were already resolved
> > > and I wanted the merged for 3.0 before revisiting it. What problem
> > > did you observe without this patch? With the lack of reference to
> > > the other thread or the previous patch, I'm assuming you found and
> > > solved the problem independently and I'd like to add a test case.
> >
> > Actually, our LKP testing didn't find this problem on this point. Even
> > with the patch, performance has no change on our machines. I just find
> > this by my eyes.
> >
>
> Dang. I figured all right that it was unlikely the patch would
> actually fix any problem but it looks correct and shouldnt' cause a
> regression. You should resend the patch to Andrew cc'ing the people
> in the old thread and linux-mm and ask Padraig Brady to test the
> patch to confirm his problem does not reappear. When it gets into
> mainline, try for -stable but I think there is very little motivation
> for merging it there.

Thanks a lot for the suggestions. I will do them.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/