[tip:irq/urgent] genirq: Fix wrong bit operation

From: tip-bot for jhbird.choi@xxxxxxxxxxx
Date: Tue Jul 26 2011 - 10:28:14 EST


Commit-ID: 1dd75f91ae713049eb6baaa640078f3a6549e522
Gitweb: http://git.kernel.org/tip/1dd75f91ae713049eb6baaa640078f3a6549e522
Author: jhbird.choi@xxxxxxxxxxx <jhbird.choi@xxxxxxxxxxx>
AuthorDate: Thu, 21 Jul 2011 15:29:14 +0900
Committer: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
CommitDate: Tue, 26 Jul 2011 16:24:02 +0200

genirq: Fix wrong bit operation

(!msk & 0x01) should be !(msk & 0x01)

Signed-off-by: Jonghwan Choi <jhbird.choi@xxxxxxxxxxx>
Link: http://lkml.kernel.org/r/1311229754-6003-1-git-send-email-jhbird.choi@xxxxxxxxxxx
Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
Cc: stable@xxxxxxxxxx
---
kernel/irq/generic-chip.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/irq/generic-chip.c b/kernel/irq/generic-chip.c
index 3a2cab4..e38544d 100644
--- a/kernel/irq/generic-chip.c
+++ b/kernel/irq/generic-chip.c
@@ -246,7 +246,7 @@ void irq_setup_generic_chip(struct irq_chip_generic *gc, u32 msk,
gc->mask_cache = irq_reg_readl(gc->reg_base + ct->regs.mask);

for (i = gc->irq_base; msk; msk >>= 1, i++) {
- if (!msk & 0x01)
+ if (!(msk & 0x01))
continue;

if (flags & IRQ_GC_INIT_NESTED_LOCK)
@@ -301,7 +301,7 @@ void irq_remove_generic_chip(struct irq_chip_generic *gc, u32 msk,
raw_spin_unlock(&gc_lock);

for (; msk; msk >>= 1, i++) {
- if (!msk & 0x01)
+ if (!(msk & 0x01))
continue;

/* Remove handler first. That will mask the irq line */
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/