[PATCH] lib/genalloc: fix gen_pool_virt_to_phys locking

From: Leo Yan
Date: Tue Jul 26 2011 - 03:16:54 EST


The func gen_pool_virt_to_phys will iterate the chunk list;
if find the correct chunk it should need release pool's lock.

Signed-off-by: Leo Yan <leoy@xxxxxxxxxxx>
---
lib/genalloc.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/lib/genalloc.c b/lib/genalloc.c
index 577ddf8..e625df5 100644
--- a/lib/genalloc.c
+++ b/lib/genalloc.c
@@ -92,8 +92,10 @@ phys_addr_t gen_pool_virt_to_phys(struct gen_pool *pool, unsigned long addr)
list_for_each(_chunk, &pool->chunks) {
chunk = list_entry(_chunk, struct gen_pool_chunk, next_chunk);

- if (addr >= chunk->start_addr && addr < chunk->end_addr)
+ if (addr >= chunk->start_addr && addr < chunk->end_addr) {
+ read_unlock(&pool->lock);
return chunk->phys_addr + addr - chunk->start_addr;
+ }
}
read_unlock(&pool->lock);

--
1.7.4.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/