Re: [Intel-gfx] [PATCH] drm/i915: Hold struct_mutex during hotplug processing

From: Keith Packard
Date: Mon Jul 25 2011 - 13:55:16 EST


On Mon, 25 Jul 2011 13:40:58 -0400, Andrew Lutomirski <luto@xxxxxxx> wrote:

> Will test tonight.

Thanks.

> It looks like there is a lot of hotplug activity when 'xset dpms force
> off' gets run. (That's not a typo. I do mean "off," not "on."

Yup, that's what I've seen as well -- do a mode set to turn stuff off
and you get spammed with hotplug events.

> See attached trace. perf rocks, even over ssh :)

Wow. You're nested about three deep in the mode setting code due to
overlapping hotplug events. What could possibly go wrong?

Makes me optimistic that a bit of locking will help a lot here.

--
keith.packard@xxxxxxxxx

Attachment: pgp00000.pgp
Description: PGP signature