Re: [PATCH] jbd: change the field "b_cow_tid" of struct journal_headfrom type unsigned to tid_t

From: Amir Goldstein
Date: Mon Jul 25 2011 - 09:25:49 EST


On Mon, Jul 25, 2011 at 4:02 PM, Wang Sheng-Hui <shhuiw@xxxxxxxxx> wrote:
> The patch is against 3.0
>
> In the definition of struct journal_head, the comment for
> the field "unsigned b_cow_tid" says the field tracks the
> last transaction id in which this buffer has been cowed.
>
> In the header part of file journal-head.h, it defines
>   typedef unsigned int  tid_t;
> We should use type tid_t to define transaction id fields.
>
> Change the field "b_cow_tid" of struct journal_head from
> type unsigned to tid_t.
>
> Signed-off-by: Wang Sheng-Hui <shhuiw@xxxxxxxxx>

my bad.

Acked-by: Amir Goldstein <amir73il@xxxxxxxxxxxx>

> ---
>  include/linux/journal-head.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/include/linux/journal-head.h b/include/linux/journal-head.h
> index 44e95d0..423cb6d 100644
> --- a/include/linux/journal-head.h
> +++ b/include/linux/journal-head.h
> @@ -45,7 +45,7 @@ struct journal_head {
>         * has been cowed
>         * [jbd_lock_bh_state()]
>         */
> -       unsigned b_cow_tid;
> +       tid_t b_cow_tid;
>
>        /*
>         * Copy of the buffer data frozen for writing to the log.
> --
> 1.7.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/