Re: linux-next: Tree for July 18 (mm/truncate.c)

From: Christoph Hellwig
Date: Mon Jul 18 2011 - 11:21:31 EST


On Mon, Jul 18, 2011 at 08:18:16AM -0700, Randy Dunlap wrote:
> On Mon, 18 Jul 2011 20:35:01 +1000 Stephen Rothwell wrote:
>
> > Hi all,
>
> mm/truncate.c:612: error: implicit declaration of function 'inode_dio_wait'
>
> mm/truncate.c should be #include-ing <linux/fs.h> for that function's
> prototype, but that doesn't help when CONFIG_BLOCK is not enabled,
> which is the case in this build failure.

Oops. Two choices here:

a) stub it out for non-blocks.
b) move it out of directio.c so that it's always provided.

I'd be fine with either one. Al, any preferences?

>
> ---
> ~Randy
> *** Remember to use Documentation/SubmitChecklist when testing your code ***
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@xxxxxxxxxx For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
> Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>
---end quoted text---
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/