Re: [PATCH] Fix loopback devices to emit uevent on auto release

From: Andrew Morton
Date: Wed Jul 06 2011 - 18:46:09 EST


On Mon, 27 Jun 2011 19:30:49 -0400
Phillip Susi <psusi@xxxxxxxxxx> wrote:

> commit 4d5498b2b400ee4781b25fa9fa219eadf11c1ef5
> Author: Phillip Susi <psusi@xxxxxxxxxx>
> Date: Mon Jun 27 18:55:00 2011 -0400
>
> Fixed loopback device to emit uevent on auto release
>
> The loopback driver failed to emit the change uevent
> when auto releasing the device. Fixed lo_release()
> to pass the bdev to loop_clr_fd() so it can emit
> the event.
>
> diff --git a/drivers/block/loop.c b/drivers/block/loop.c
> index dbf31ec..ba915ce 100644
> --- a/drivers/block/loop.c
> +++ b/drivers/block/loop.c
> @@ -1522,7 +1522,7 @@ static int lo_release(struct gendisk *disk, fmode_t mode)
> * In autoclear mode, stop the loop thread
> * and remove configuration after last close.
> */
> - err = loop_clr_fd(lo, NULL);
> + err = loop_clr_fd(lo, lo->lo_device);
> if (!err)
> goto out_unlocked;
> } else {

The patch is missing your Signed-off-by:. Please review
Documentation/SubmittingPatches section 12 to see what this means.
Then, if agreeable, please send us that Signed-off-by:, thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/