Re: [tip:x86/cleanups] x86, smpboot: Mark names[] array as const

From: Brian Gerst
Date: Thu Jun 30 2011 - 21:20:34 EST


On Thu, Jun 30, 2011 at 8:47 PM, H. Peter Anvin <hpa@xxxxxxxxxxxxxxx> wrote:
> On 06/30/2011 05:41 PM, Greg Dietsche wrote:
>> On Thu, Jun 30, 2011 at 05:25:36PM -0700, H. Peter Anvin wrote:
>>> On 06/30/2011 05:21 PM, tip-bot for Greg Dietsche wrote:
>>>> + Â const char const *names[] = { "ID", "VERSION", "SPIV" };
>>> Â Â Â Â ^^^^^^^^^^^^^^^^
>>>
>>> Doesn't make sense, patch removed...
>>>
>> could you explain a little more? I don't see my mistake.
>> it compiles and is running on my box currently.
>>

One const is for the strings, the other is for the array of pointers.

--
Brian Gerst
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/