Re: [PATCH] slub: reduce overhead of slub_debug

From: David Daney
Date: Tue Jun 28 2011 - 15:40:40 EST


On 06/28/2011 12:32 PM, Christoph Lameter wrote:
On Sun, 26 Jun 2011, Marcin Slusarz wrote:

slub checks for poison one byte by one, which is highly inefficient
and shows up frequently as a highest cpu-eater in perf top.

Ummm.. Performance improvements for debugging modes? If you need
performance then switch off debuggin.

There is no reason to make things gratuitously slow. I don't know about the merits of this particular patch, but I must disagree with the general sentiment.

We have high performance tracing, why not improve this as well.

Just last week I was trying to find the cause of memory corruption that only occurred at very high network packet rates. Memory allocation speed was definitely getting in the way of debugging. For me, faster SLUB debugging would be welcome.

David Daney
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/