Re: [PATCH v2 21/22] KVM: MMU: mmio page fault support

From: Xiao Guangrong
Date: Thu Jun 23 2011 - 22:02:35 EST


On 06/24/2011 04:13 AM, Marcelo Tosatti wrote:

>> No, not all no mmio spte is considered a genuine EPT misconfig, as the above
>> case, we can get !is_mmio_spte(), but it is not the genuine EPT misconfig
>> since it is caused by shadow page zapped
>
> I mean it must be
>
> if (is_mmio_spte(spte))
> handle_mmio
> if (spte == spte_not_present) /* race, let CPU refault */
> return
> handle EPT misconf
>

The patch already did it as you say :p

if (is_mmio_spte(spte))
return handle_mmio
if (spte_present(spte))
return handle EPT misconfig

return page fault path /*I will fix it, let cpu refault instead*/

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/