Re: [PATCH] dt: add of_get_property_value32 helper function

[Grant Likely]

On Thu, Jun 23, 2011 at 10:38 AM, Rob Herring <robherring2@xxxxxxxxx> wrote:
> From: Rob Herring <rob.herring@xxxxxxxxxxx>
>
> A common use of of_get_property in driver is to just get a 32-bit integer
> value, but the interface is a bit complicated in that case. Add a helper
> function that just fills in the value.

Hey Rob,

I already asked Thomas Abraham to write a patch that does exactly
this.  He's already posted his first draft to the list.  His version
also covers u64 and strings, so I'm going to let him respin his
version and pick that one up.

> Grant,
>
> I noticed most callers of of_get_property don't do be32_to_cpup on the
> returned pointer. Most instances appear to be powerpc only drivers, but
> should of_get_property return ptr be __be32?

No.  Not all properties contain cell values.  Having of_get_property
return void* is the correct behaviour.

g.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/